git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/6] MyFirstContribution: what if I don't get a reply?

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 17, 2026, 14:59 UTC
Message-ID
<xmqqwlut64rx.fsf@gitster.g>
In-Reply-To
<aloOAwOtutgPbJu2@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 26 quoted lines
> On Sat, Jul 11, 2026 at 12:26:46PM -0700, Junio C Hamano wrote:
>> Tell readers that pinging is a perfectly sensible thing to do when
>> they do not see a response.
>> 
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>> ---
>>  Documentation/MyFirstContribution.adoc | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>> 
>> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
>> index 4832e5bad5..fc2ce2e785 100644
>> --- a/Documentation/MyFirstContribution.adoc
>> +++ b/Documentation/MyFirstContribution.adoc
>> @@ -1438,6 +1438,19 @@ substantial rework, and mention which parts of the current series will become
>>  obsolete so reviewers can avoid spending time on them until the updated series
>>  is ready.
>>  
>> +=== What if I don't get a reply?
>> +
>> +If you don't receive any review comments after a week or two, do not
>> +assume your patch has been accepted or merged.  In the Git project,
>> +silence does not equal approval.  It usually means reviewers are busy
>> +or haven't noticed your contribution.
>
> Should we also add the third reason: reviewers are simply not interested
> in the patch? It's a bit brutal, but that's quite a common reason, too.
Yeah, I agree that it would make a good addition.
Previous: Patrick SteinhardtNext: Junio C Hamano
Message 13 of 21 in “Update Contributor Guides”
  1. 0/6 Update Contributor GuidesJunio C Hamano, Jul 11, 2026
  2. 1/6 SubmittingPatches: clarify expected structure of commit log messageJunio C Hamano, Jul 11, 2026
  3. Weijie YuanJul 12, 2026
  4. Junio C HamanoJul 12, 2026
  5. Weijie YuanJul 13, 2026
  6. Michael MontalboJul 12, 2026
  7. Junio C HamanoJul 13, 2026
  8. Weijie YuanJul 13, 2026
  9. D. Ben KnobleJul 14, 2026
  10. Weijie YuanJul 17, 2026
  11. 2/6 MyFirstContribution: what if I don't get a reply?Junio C Hamano, Jul 11, 2026
  12. Patrick SteinhardtJul 17, 2026
  13. Junio C HamanoJul 17, 2026
  14. 3/6 MyFirstContribution: carrying over trailersJunio C Hamano, Jul 11, 2026
  15. 4/6 MyFirstContribution: clarify that 'seen' does not mean acceptanceJunio C Hamano, Jul 11, 2026
  16. Matt HunterJul 12, 2026
  17. Junio C HamanoJul 12, 2026
  18. 5/6 SubmittingPatches: clarify the meaning of "Will queue"Junio C Hamano, Jul 11, 2026
  19. 6/6 SubmittingPatches: clarify the writing style of whats-cookingJunio C Hamano, Jul 11, 2026
  20. Michael MontalboJul 12, 2026
  21. Junio C HamanoJul 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.