git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Outreachy PATCH] delta-islands: use Q_() for island count

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 13, 2026, 20:33 UTC
Message-ID
<xmqqwlrluyq6.fsf@gitster.g>
In-Reply-To
<CAFpMFfAQET2OvZB905cajvhSG6BS9t4zx5G6iGG6BUP_o8wUGQ@mail.gmail.com>
Okhuomon Ajayi <okhuomonajayi54@gmail.com> writes:
Show 11 quoted lines
> On Tue, Oct 13, 2026 at 7:00 PM Junio C Hamano <gitster@pobox.com> wrote:
>
>> I am not sure of the value in this, though.  You certainly do not
>> mean to say that you updated all of the ones that you found with the
>> above.  You are not inviting others to do the same grep and "fix"
>> any of the hits, as the pattern gives too many false positives
>> (i.e., not all %d are about number of things, like the line number a
>> parser has found the error it is reporting at), and without warning
>> that, it would not be helpful to these others.
>
> You are right, I will remove it from the commit message and send a v2.

I think is is common to have such a "not quite suited for the permanent commit log message, but may help reviewers and others who are reading the patch while it is still being worked on" material under the three-dash line below your sign-off.

Show 8 quoted lines
>
>> The change itself looks sensible to me.
>
> Thank you for the review.
>
> Okhuomon
>
> Okhuomon
Previous: Okhuomon AjayiNext: Okhuomon Ajayi
Message 5 of 8 in “[Outreachy] Introduction: Okhuomon Ajayi, microproject in delta-islands.c”
  1. Okhuomon AjayiOct 13, 2026
  2. delta-islands: use Q_() for island countOkhuomon Ajayi, Oct 13, 2026
  3. Junio C HamanoOct 13, 2026
  4. Okhuomon AjayiOct 13, 2026
  5. Junio C HamanoOct 13, 2026
  6. delta-islands: use Q_() for island countOkhuomon Ajayi, Oct 13, 2026
  7. Usman AkinyemiOct 13, 2026
  8. Okhuomon AjayiOct 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.