Re: [PATCH 0/2] add notes.merge configuration variable
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 31, 2015, 20:00 UTC
- Message-ID
- <xmqqvbd03xo5.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1438370496-26433-1-git-send-email-jacob.e.keller@intel.com>
CC'ing yourself is ok, but please do not forget to ask reviews from people who have touched the area of the code you are touching (they are hopefully the ones who are more knowledgeable and can help you).
Old timers like I know Johan is the go-to person on things around notes, but new people can ask their copy of Git:
$ git shortlog -n -s --no-merges master builtin/notes.c notes.c | head -n 5
46 Johan Herland
11 Junio C Hamano
11 Michael Haggerty
5 Jeff King
5 Nguyễn Thái Ngọc DuyThe changes to the code looked reasonable from a cursory read, though.
Thanks.