Re: Solaris: Fail to build git with CFLAGS=-m64

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 13, 2015, 07:39 UTC
Message-ID: <xmqqvbab9pz7.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAKzKBF0MH+f3=frtwwxKfaELNXm4fCR5LWVhvJ7-YQF-ngfM+g@mail.gmail.com>

evgeny litvinenko <evgeny.v.litvinenko@gmail.com> writes:

Show 10 quoted lines

> Solaris has the following prototype in the file /usr/include/arpa/inet.h:
>
> extern const char *inet_ntop(int, const void *_RESTRICT_KYWD, char
> *_RESTRICT_KYWD, socklen_t);
>
> Git's prototype for inet_ntop is in file git-compat-util.h:
>
> #ifdef NO_INET_NTOP
> const char *inet_ntop(int af, const void *src, char *dst, size_t size);
> #endif

This tells me that it is designed to be used only when the platform does not offer inet_ntop(). If your platform does have it, why is your build define NO_INET_NTOP?

Perhaps configure generated by autoconf is faulty?

In this project, use of autoconf/configure is optional---in other words, it is expected that you can build successfully by setting and unsetting necessary Makefile macros in your own config.mak without using autoconf/configure at all. I'd try without configure and make sure I do not define NO_INET_NTOP (and if you have inet_pton(), then make sure you do not define NO_INET_PTON either) in config.mak if I were you.