Re: [PATCH] daemon, path.c: fix a bug with ~ in repo paths

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 18, 2016, 17:08 UTC
Message-ID: <xmqqvawppote.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20161018150629.23205-1-lukeshu@sbcglobal.net>

Luke Shumaker <lukeshu@sbcglobal.net> writes:

> The superficial aspect of this change is that git-daemon now allows paths
> that start with a "~".  Previously, if git-daemon was run with
> "--base-path=/srv/git", it was impossible to get it to serve
> "/srv/git/~foo/bar.git".

I am not sure I understand what you are saying here.  Do you mean

    I have a path on my server /srv/git/~foo/bar.git; the tilde does
    not mean anything special--it is just a byte in a valid pathname.

    I want to allow my users to say

	git fetch git://my.server/~foo/bar.git

    and fetch from that repository, but "git daemon" lacks the way
    to configure to allow it.

If that is the case, what happens instead? Due to the leading "~foo/" getting noticed as an attempt to use the user-path expansion it is not treated as just a literal character?

I am not sure if it is even a bug. As you can easily lose that tilde that appears in front of subdirectory of /srv/git/ or replace it with something else (e.g. "u/"), this smells like "Don't do it if it hurts" thing to me.