git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Remove help advice text from git editors for interactive rebase and reword

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 24, 2017, 21:47 UTC
Message-ID
<xmqqvamhbj7z.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20170724184707.22828-1-szeder.dev@gmail.com>
SZEDER Gábor <szeder.dev@gmail.com> writes:
Show 6 quoted lines
> While these reminders are useful for new users, with time they learn
> what the score is, and experienced users might find these advices are
> just wasting a couple of lines' worth of screen real estate.
>
> Make displaying these advices configurable via the 'advice.commitMsg'
> config variable.

It may not be a bad idea, but the code after the patch does look ugly with too deep indentation levels. Can some refactoring help, I wonder?

Is that advice.commitMsg? It looks more like commitEditor advice to me but it may be just me.

Previous: SZEDER Gábor
Message 7 of 7 in “Remove help advice text from git editors for interactive rebase and reword”
  1. Kirill LikhodedovJul 23, 2017
  2. Alexei LozovskyJul 23, 2017
  3. Junio C HamanoJul 23, 2017
  4. Kirill LikhodedovJul 23, 2017
  5. Jeff KingJul 24, 2017
  6. SZEDER GáborJul 24, 2017
  7. Junio C HamanoJul 24, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.