Re: [PATCH v1] travis-ci: fix "skip_branch_tip_with_tag()" string comparison

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 22, 2017, 01:57 UTC
Message-ID: <xmqqvakblckw.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <4FC081C4-355E-4E62-8CD8-89C299485182@gmail.com>

Lars Schneider <larsxschneider@gmail.com> writes:

Show 6 quoted lines

> Oh, you're right!
>
>
>> Could you squash in the following?
>
> @Junio: Can you squash it when you apply the patch?

I do not mind and I already did.

The patches in the series this patch is fixing up were solely about splitting these scripts out of the YAML file as-is, and I think it was correct to carry these style differences over without adjusting them.

But resulting scripts in ci/ are riddled with styleguide deviations, which may want to be cleaned up later. There also are some bash-isms marked with "#!env bash" in them, but I think they are OK because we know we are running them only at a very specific place and the need to make them portable is very small.

Thanks.