Re: [PATCH] completion: add missing completions for log, diff, show

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 8, 2017, 04:06 UTC
Message-ID: <xmqqvaill8h1.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAFA_24+bhK5i1Rbp+04+g1Zo6Z8zpmobb5DcJBEtuG1NMBZ8-A@mail.gmail.com>

Max Rothman <max.r.rothman@gmail.com> writes:

Show 5 quoted lines

> How about this:
>
> The bash completion script knows some options to "git log" and
> "git show" only in the positive form, (e.g. "--abbrev-commit"), but not
> in their negative form (e.g. "--no-abbrev-commit"). Adds them.

s/Adds them/Add them/; we speak as if we are giving an order to the codebase to "become like so" (or to the patch monkey to "make the code so").

> Also, the bash completion script is missing some other options to
> "git diff", and "git show" (and thus, all other commands that take
> "git diff"'s options). Adds them. Of note, since "--indent-heuristic" is
> no longer experimental, adds that too.

Likewise for the two "adds".

Show 8 quoted lines

>>> ---
>>
>> Missed sign-off?
>
> Whoops, there doesn't seem to be a way to add that separately from the
> commit message in the submitGit interface. I'll try adding it, but
> gmail might turn all the tabs into spaces, so if it does, I'll try to
> figure out how to resubmit.

I would imagine that the cleanest way is to "commit --amend" and have submitGit see that updated/corrected copy.

Thanks.