Re: [RFC PATCH v2 1/1] rebase-interactive: Add git_rebase__interactive__preserve_merges
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 21, 2018, 22:43 UTC
- Message-ID
- <xmqqvadpm4m0.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <CAKk8isqopygpS0BfPi7Xa3jVTacptup-WKusZ3rzRzgU_WDaZg@mail.gmail.com>
Wink Saville <wink@saville.com> writes:
Show 15 quoted lines
>> Good code simplification that turns >> >> if A >> if B >> do this thing >> fi >> fi >> >> into >> >> if A & B >> do this thing >> fi > > Will be keeping this in a future commit
I think this one is simple enough to be in the "prelim clean-up" change, so that you can reduce the size of the remaining stuff that really needs focused review.
> But if that doesn't come to past, I believe my goal of simplication and fixing: > "not ok 24 - exchange two commits with -p # TODO known breakage" > In t3404-rebase-interactive.sh is worth while.
Oh, thanks for working on this.