Re: [BUG] url schemes should be case-insensitive

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 25, 2018, 18:19 UTC
Message-ID: <xmqqvaa6ohiw.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180624085622.GA28575@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

> We seem to match url schemes case-sensitively:
>
>   $ git clone SSH://example.com/repo.git
>   Cloning into 'repo'...
>   fatal: Unable to find remote helper for 'SSH'
>
> whereas rfc3986 is clear that the scheme portion is case-insensitive.
> We probably ought to match at least our internal ones with strcasecmp.

That may break if somebody at DevToolGroup@$BIGCOMPANY got cute and named their custom remote helper SSH:// that builds on top of the normal ssh:// protocol with something extra and gave it to their developers (and they named the http counterpart that has the same extra HTTP://, of course). If we probe for git-remote-SSH first and then fall back to git-remote-ssh, then we won't break these people, though. I agree that it may be a good bite-sized #leftoverbit material.

> Possibly we should also normalize external helpers (so "FOO://bar" would
> always call git-remote-foo, never git-remote-FOO).

Show 10 quoted lines

> We could probably also give an advise() message in the above output,
> suggesting that the problem is likely one of:
>
>   1. They misspelled the scheme.
>
>   2. They need to install the appropriate helper.
>
> This may be a good topic for somebody looking for low-hanging fruit to
> get involved in development (I'd maybe call it a #leftoverbits, but
> since I didn't start on it, I'm not sure if it counts as "left over" ;)).

Well, noticing an issue, analysing and discussing potential improvements and their ramifications is already half the work, so it does count as left-over, I would say.

It may probably be a good idea to do an advice, but I'd think "Untable to find remote helper for 'SSH'" may be clear enough. If anything, perhaps saying "remote helper for 'SSH' protocol" would make it even clear? I dunno.