Re: [PATCH] reopen_tempfile(): truncate opened file

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 5, 2018, 16:54 UTC
Message-ID: <xmqqva7j51gt.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180905154827.GC24660@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 12 quoted lines

>> > So AFAIK this fsck catches everything and yields a non-zero exit in the
>> > error case. And it should work for even a single byte of rubbish.
>> 
>> Yes you're right. I forgot about the trailing hash.
>
> Thanks, I was worried that I was missing something. ;)
>
> Maybe it is worth making that final comment:
>
>   # and that the trailing hash in the index was not corrupted,
>   # which should catch even a single byte of cruft
>   git fsck

Perhaps. I do not mind seeing an additional comment to explain why this requires PERL (it wasn't immediately obvious as I never use 'commit -p' myself), either.