Re: [PATCH v2] git-compat-util: undefine fileno if defined
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 8, 2019, 10:16 UTC
- Message-ID
- <xmqqv9ylfdzj.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <CACsJy8BcyD199L4qGv6-TP-8HD+GS+ZDNN5jspkh5uVaWekkoQ@mail.gmail.com>
Duy Nguyen <pclouds@gmail.com> writes:
Show 5 quoted lines
> I don't think the other two were the problem. Even in the mail you > pointed to, only fileno() is acknowledged the problem in the commit > message. > > At least for BSDs fflush() and rewind() are not macros.
I can drop the dm/some-stdio-functions-are-macro-on-freebsd topic safely then. That was the most important thing I wanted to know about ;-)
> Let's see if there are still problems with more exotic platforms. I'm > reluctant of adding unused compat/ code because to me compat/ is > scary.
Right. Thanks.