Re: [PATCH 1/1] ci: split the `linux-gcc` job into two jobs

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 13, 2019, 15:56 UTC
Message-ID: <xmqqv9x9wkba.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190613153354.GC31952@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

Show 17 quoted lines

> On Thu, Jun 13, 2019 at 05:53:51AM -0700, Johannes Schindelin via GitGitGadget wrote:
>> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>> 
>> This job was abused to not only run the test suite in a regular way but
>> also with all kinds of `GIT_TEST_*` options set to non-default values.
>> 
>> Let's split this into two
>
> Why...?
>
>> with the `linux-gcc` job running the default
>> test suite, and the newly-introduced `linux-gcc-extra` job running the
>> test suite in the "special" ways.
>> 
>> Technically, we would have to build Git only once, but it would not be
>> obvious how to teach Travis to transport build artifacts, so we keep it
>> simple and just build Git in both jobs.

I had the same reaction.

If it said something like:

    There is no logical reason why these extras need to be tied to
    the linux-gcc platform.  instead of tying the extra
    configuration tests only to linux-gcc, split it so that they are
    also run on all other combinations, and this is merely a first
    step of doing so

it might at least have been possible to judge if the motivation is sane, but the proposed log message, while it is quite clear what is being done and what its shortcomings are, is silent on why we would want to do this in the first place, and that makes it even harder to swallow the shortcomings.

Thanks.