Re: Change behavior of git add --patch on newly added file?

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 13, 2019, 01:47 UTC
Message-ID: <xmqqv9roczt2.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20191112184720.GB38770@google.com>

Emily Shaffer <emilyshaffer@google.com> writes:

Show 9 quoted lines

>> Patches welcome, but you may want to check with Dscho as there is an
>> effort going on to reimplement the entire "add -i" machinery in C.
>
> Ah, this is a compelling point. I imagine the landscape will be fairly
> different when that effort is finished.
>
>
> From the replies, it sounds like it's a favorable change, but it makes
> sense to wait on it considering the refactor to use C. Thanks, all.

Peff's "how would you tell between genuinely untracked ones and those you would want to add" and "should 'add -p' with no pathspec attempt to 'add -N' everything under the sun?" are both quite valid points. I already raised "'add -N && add -p' would give you a single hunk that adds everything. Are you willing to manually split, and how well would it work?" in a separate message. These design issues can be resolved without coding, and should be resolved before you start randomly typing ;-)

Thanks.