Re: [PATCH] credential: treat "?" and "#" in URLs as end of host

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 15, 2020, 18:39 UTC
Message-ID: <xmqqv9m061aj.fsf@gitster.c.googlers.com>
In-Reply-To: <20200414214304.GA1887601@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 9 quoted lines

> -	slash = strchrnul(cp, '/');
> +
> +	/*
> +	 * A query or fragment marker before the slash ends the host portion.
> +	 * We'll just continue to call this "slash" for simplicity. Notably our
> +	 * "trim leading slashes" part won't skip over this part of the path,
> +	 * but that's what we'd want.
> +	 */
> +	slash = cp + strcspn(cp, "/?#");

Whatever happened when the original did not find any slash should happen in the new code when none of these three terminating bytes is found. The original made slash point at the end of the string, and the new code does the same.

So, by definition, the code is correct ;-)

Show 10 quoted lines

> diff --git a/t/t0300-credentials.sh b/t/t0300-credentials.sh
> index 5b78ebbc3f..b6ec676989 100755
> --- a/t/t0300-credentials.sh
> +++ b/t/t0300-credentials.sh
> @@ -443,11 +443,45 @@ test_expect_success 'url parser ignores embedded newlines' '
>  	username=askpass-username
>  	password=askpass-password
>  	--
> -	warning: url contains a newline in its host component: https://one.example.com?%0ahost=two.example.com/
> +	warning: url contains a newline in its path component: https://one.example.com?%0ahost=two.example.com/

Nice demonstration ;-).