Re: [PATCH] pretty-options.txt: fix --no-abbrev-commit description

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 26, 2020, 17:56 UTC
Message-ID: <xmqqv9h5uw7u.fsf@gitster.c.googlers.com>
In-Reply-To: <20200826144923.16806-1-sorganov@gmail.com>

Sergey Organov <sorganov@gmail.com> writes:

Show 6 quoted lines

>  --no-abbrev-commit::
>  	Show the full 40-byte hexadecimal commit object name. This negates
> -	`--abbrev-commit` and those options which imply it such as
> -	"--oneline". It also overrides the `log.abbrevCommit` variable.
> +	`--abbrev-commit`, either explicit or implied by other options such
> +	as "--oneline". It also overrides the `log.abbrevCommit` variable.

I personally do not think it would be crazy to misread that one-line format itself would be defeated when no abbreviation of object names is requested, so from that point of view, the original text would be OK enough, but as long as the updated text is easier to understand, that is fine ;-)

Keeping the original sentence structure, e.g.

    ... and those options which imply abbreviating commit object
    names such as ...

would have been what I wrote, instead of "either explicit or implied by", though.

Thanks.