Re: [PATCH resend] graph: improve grammar of "invalid color" error message

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 15, 2021, 03:55 UTC
Message-ID: <xmqqv96fwzlx.fsf@gitster.g>
In-Reply-To: <20210612184144.6894-1-alexhenrie24@gmail.com>

Alex Henrie <alexhenrie24@gmail.com> writes:

Show 6 quoted lines

> Without the "d", it sounds like a command, not an error, and is liable
> to be translated incorrectly.
>
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
> Resending to make sure that this patch isn't forgotten.

Thanks, will queue.

Show 17 quoted lines

> ---
>  graph.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/graph.c b/graph.c
> index c128ad0cce..e3828eb8f2 100644
> --- a/graph.c
> +++ b/graph.c
> @@ -95,7 +95,7 @@ static void parse_graph_colors_config(struct strvec *colors, const char *string)
>  		if (!color_parse_mem(start, comma - start, color))
>  			strvec_push(colors, color);
>  		else
> -			warning(_("ignore invalid color '%.*s' in log.graphColors"),
> +			warning(_("ignored invalid color '%.*s' in log.graphColors"),
>  				(int)(comma - start), start);
>  		start = comma + 1;
>  	}