Re: [GSoC] [PATCH v2 2/9] submodule--helper: refactor resolve_relative_url() helper

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 5, 2021, 20:13 UTC
Message-ID: <xmqqv94jk5to.fsf@gitster.g>
In-Reply-To: <20210805074054.29916-3-raykar.ath@gmail.com>

Atharva Raykar <raykar.ath@gmail.com> writes:

Show 7 quoted lines

> Refactor the helper function to resolve a relative url, by reusing the
> existing `compute_submodule_clone_url()` function.
>
> `compute_submodule_clone_url()` performs the same work that
> `resolve_relative_url()` is doing, so we eliminate this code repetition
> by moving the former function's definition up, and calling it inside
> `resolve_relative_url()`.

Looking good.

Show 6 quoted lines

> Signed-off-by: Atharva Raykar <raykar.ath@gmail.com>
> Mentored-by: Christian Couder <christian.couder@gmail.com>
> Mentored-by: Shourya Shukla <periperidip@gmail.com>
> ---
>  builtin/submodule--helper.c | 61 +++++++++++++++----------------------
>  1 file changed, 25 insertions(+), 36 deletions(-)

This step is easier to see with "show --patience --color-moved" to see that compute_submodule_clone_url() has only been moved without any change. And the actual change is much smaller than what the diffstat suggests above (11 lines lost, 1 line updated, if I counted correctly).

Nicely done.