git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] README.md: add CodingGuidelines and a link for Translators

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 15, 2022, 00:47 UTC
Message-ID
<xmqqv8yl6d0f.fsf@gitster.g>
In-Reply-To
<6b626f9d-05d6-1903-0b38-e3566e357472@iee.email>
Philip Oakley <philipoakley@iee.email> writes:
> Unfortunately it `[]` is not working for me for the new additions.
> GitHub magic?
Let's step back a bit.

Is there somebody reading README.md as a more generic MarkDown? I do not think our build procedure creates any rendered document from it.

My recollection was that we moved from README.txt to README.md for the sole purpose of showing it https://github.com/git/git/ as more than just a plain text, so it is a hard requirement that GitHub flavored MarkDown renderer is happy with whatever we write in the file.

If GitHub flavored MarkDown only supports [] and breaks with (), then there is no need for further discussion. We must stick to [] that has been working for us in the file.

On the other hand, if both () and [] work well at GitHub, I am OK to replace [] to (), so that it shows well at GitHub and also it can be used with other MarkDown renderers.

I prefer, from the organizational point of view, to see two patches, in this order, if we were to go that way.

 [PATCH 1/2] README: link to more contributor documents

which uses [] (not ()). After this, README.md uses only [], including the two links you add in this step. And then

 [PATCH 2/2] README: use "()", not "[]", to please more MarkDown processors
which replaces all uses of [] with ().

That would allow us to queue both, try them out, and we can back out [2/2] if GitHub's renderer does not like the result.

Previous: Philip OakleyNext: Philip Oakley via GitGitGadget
Message 4 of 11 in “README.md: add CodingGuidelines and a link for Translators”
  1. README.md: add CodingGuidelines and a link for TranslatorsPhilip Oakley via GitGitGadget, Jan 14, 2022
  2. Junio C HamanoJan 14, 2022
  3. Philip OakleyJan 15, 2022
  4. Junio C HamanoJan 15, 2022
  5. README.md: add CodingGuidelines and a link for TranslatorsPhilip Oakley via GitGitGadget, Jan 16, 2022
  6. Junio C HamanoJan 16, 2022
  7. Philip OakleyJan 17, 2022
  8. Bagas SanjayaJan 17, 2022
  9. Philip OakleyJan 17, 2022
  10. Junio C HamanoJan 17, 2022
  11. README.md: add CodingGuidelines and a link for TranslatorsPhilip Oakley via GitGitGadget, Jan 17, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.