git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/2] bisect: status improvements when bisect is not fully fleshed out

From
Junio C Hamano <gitster@pobox.com>
Date
May 11, 2022, 19:41 UTC
Message-ID
<xmqqv8ubkgbo.fsf@gitster.g>
In-Reply-To
<cover.1652291688.git.chris@chrisdown.name>
Chris Down <chris@chrisdown.name> writes:
Show 25 quoted lines
> When bisecting, we currently don't output anything before bisection
> starts in earnest, which can result in some confusion. For example, in
> the case illustrated in the first commit in this patch series, it's
> trivial to accidentally misspell a tag or branch and accidentally end up
> in an unintended state with no clear indication about what happened.
>
> This patch series makes it so that we give information about bisect
> state even before the bisect is ready to begin. We also store these
> changes in state to the bisect log.
>
> v2:
>
> - Move to improve bisect output overall, instead of just warning for the
>   specific unintended pathspec case.
>
> v3:
>
> - Fix test indentation
> - Rename bs to state
> - Use `unsigned int' for nr_{good,bad}
> - Pass the bisect state struct as an argument into bisect_print_status
> - Zero-initialise bisect_state directly, don't use memset()
> - Fix multiline comment style in bisect.h
> - Use strbuf in bisect_log_printf
> - Change `git bisect log' use an output file in tests instead of piping

Will replace. Unless there are more inputs, let's merge it to 'next'. This round looks more than good enough to me.

Thanks.  
Previous: Chris Down
Message 4 of 4 in “bisect: status improvements when bisect is not fully fleshed out”
  1. 0/2 bisect: status improvements when bisect is not fully fleshed outChris Down, May 11, 2022
  2. 1/2 bisect: output state before we are ready to compute bisectionChris Down, May 11, 2022
  3. 2/2 bisect: output bisect setup status in bisect logChris Down, May 11, 2022
  4. Junio C HamanoMay 11, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.