git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] am: Allow passing --no-verify flag

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 27, 2022, 01:27 UTC
Message-ID
<xmqqv8n19ofx.fsf@gitster.g>
In-Reply-To
<Y4D+UU6l3YN9r9Xn@orome>
Thierry Reding <thierry.reding@gmail.com> writes:
Show 5 quoted lines
> Thinking a bit more about this, if we let applypatch-msg run but ignore
> failures and continue on to commit the result, wouldn't that potentially
> allow committing garbage? I'm thinking about cases where applypatch-msg
> may attempt to normalize the message and fails badly, leaving a partial
> commit message or none at all.

That is a very reasonable way to think about this. So I am sold on your approach of not running the hook at all.

Thanks.
Previous: Thierry Reding
Message 4 of 4 in “am: Allow passing --no-verify flag”
  1. am: Allow passing --no-verify flagThierry Reding, Nov 19, 2022
  2. Junio C HamanoNov 21, 2022
  3. Thierry RedingNov 25, 2022
  4. Junio C HamanoNov 27, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.