Re: [PATCH 1/3] do full type check in COPY_ARRAY and MOVE_ARRAY

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 1, 2023, 12:46 UTC
Message-ID: <xmqqv8lqfmmb.fsf@gitster.g>
In-Reply-To: <269d85de-1448-0198-8251-9af898fedc67@web.de>

René Scharfe <l.s.r@web.de> writes:

> Ah, right, __builtin_types_compatible_p returns 0 in this case and an
> assignment is silently allowed.

Thanks. There is another thing I forgot to mention. I think the side that can use __builtin_types_compatible_p() can lose the assignment check (what I wrote had the GCC extension in addition to the assignment check instead), i.e. the assignment check from your original patch can be considered as a fallback position for compilers without the GCC extension.