git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (May 2024, #12; Tue, 28)

From
Junio C Hamano <gitster@pobox.com>
Date
May 29, 2024, 14:24 UTC
Message-ID
<xmqqv82w1yru.fsf@gitster.g>
In-Reply-To
<Zla7oBd7UZbPX7d8@tanuki>
Patrick Steinhardt <ps@pks.im> writes:
Show 32 quoted lines
> On Tue, May 28, 2024 at 03:45:05PM -0700, Junio C Hamano wrote:
>> * ps/undecided-is-not-necessarily-sha1 (2024-05-06) 15 commits
>>   (merged to 'next' on 2024-05-08 at 9f8e894685)
>>  + repository: stop setting SHA1 as the default object hash
>>  + oss-fuzz/commit-graph: set up hash algorithm
>>  + builtin/shortlog: don't set up revisions without repo
>>  + builtin/diff: explicitly set hash algo when there is no repo
>>  + builtin/bundle: abort "verify" early when there is no repository
>>  + builtin/blame: don't access potentially unitialized `the_hash_algo`
>>  + builtin/rev-parse: allow shortening to more than 40 hex characters
>>  + remote-curl: fix parsing of detached SHA256 heads
>>  + attr: fix BUG() when parsing attrs outside of repo
>>  + attr: don't recompute default attribute source
>>  + parse-options-cb: only abbreviate hashes when hash algo is known
>>  + path: move `validate_headref()` to its only user
>>  + path: harden validation of HEAD with non-standard hashes
>>  + Merge branch 'ps/the-index-is-no-more' into ps/undecided-is-not-necessarily-sha1
>>  + Merge branch 'jc/no-default-attr-tree-in-bare' into ps/undecided-is-not-necessarily-sha1
>>  (this branch is used by jc/undecided-is-not-necessarily-sha1-fix.)
>> 
>>  Before discovering the repository details, We used to assume SHA-1
>>  as the "default" hash function, which has been corrected. Hopefully
>>  this will smoke out codepaths that rely on such an unwarranted
>>  assumptions.
>> 
>>  Will cook in 'next', as it has known breakage.
>>  source: <cover.1715057362.git.ps@pks.im>
>
> The follow-up patches in jc/undecided-is-not-necessarily-sha1-fix have
> landed by now, so there are no more known breakages at the current
> point, right? Do we want to merge this down now, or is there something
> you'd like me to do in this context?

I think "known breakage" is gone, but I had this on back-burner as I wanted to forcus on cleaning up the 2.45.1 mess first X-<.

Let's unblock the topic by lifting "Will cook" mark.  Thanks.
Previous: Patrick SteinhardtNext: Ghanshyam Thakkar
Message 3 of 5 in “What's cooking in git.git (May 2024, #12; Tue, 28)”
  1. Junio C HamanoMay 28, 2024
  2. Patrick SteinhardtMay 29, 2024
  3. Junio C HamanoMay 29, 2024
  4. Ghanshyam ThakkarMay 29, 2024
  5. Junio C HamanoMay 29, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.