Re: [PATCH] t5500: fix mistaken $SERVER reference in helper function

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 20, 2024, 18:06 UTC
Message-ID: <xmqqv823v68c.fsf@gitster.g>
In-Reply-To: <ZnM3I11IRporu4sj@google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 13 quoted lines

> Alas, in a copy-and-paste gone wrong, 07ef3c6604 gets the name of the
> blob (but not the commit) from "server" instead of $SERVER.  And this
> happens to work because the first time we call this helper, $SERVER is
> "server".  The only reason this happens to work at all is that we're
> looking at a blob id; if we looked at the commit id, then the
> timestamps wouldn't have matched.
>
> Thanks, the fix is obviously correct.
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
> Particularly telling that the author of 07ef3c6604 introduced this
> typo while trying to make the tests _more_ robust.

;-)

Thanks both.