Re: git rebase --continue error message is misleading
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 10, 2025, 16:59 UTC
- Message-ID
- <xmqqv7thburt.fsf@gitster.g>
- In-Reply-To
- <CALG+76erpDGFinXsockB8=+GPEoEtd+xw=xVN1HCzv7=aFymoA@mail.gmail.com>
Björn Lindqvist <bjourne@gmail.com> writes:
> Here, I don't think assuming the user has vi installed is correct.
Exporting GIT_EDITOR that points at the editor of your choice is exactly for those who choose to use something else. Instead of erroring out with "You haven't told me what editor you want to use", editor.c has a fallback default to use DEFAULT_EDITOR that can be configured at the compile time, and if the builder does not configure it, then it falls back to "vi". We'd need to stop somewhere ;-)