Re: [PATCH v5] blame: print unblamable and ignored commits in porcelain mode
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 8, 2025, 00:32 UTC
- Message-ID
- <xmqqv7rfze4r.fsf@gitster.g>
- In-Reply-To
- <2fbecc76-c3d9-4a8e-9326-5b83db1ceb26@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 15 quoted lines
> Hi Karthik > > On 03/04/2025 17:03, Karthik Nayak wrote: >> The 'git-blame(1)' command allows users to ignore specific revisions via >> the '--ignore-rev <rev>' and '--ignore-revs-file <file>' flags. These >> flags are often combined with the 'blame.markIgnoredLines' and >> 'blame.markUnblamableLines' config options. These config options prefix >> ignored and unblamable lines with a '?' and '*', respectively. >> However, this option was never extended to the porcelain mode of >> 'git-blame(1)'. Since the documentation does not indicate this >> exclusion, it is a bug. >> Fix this by printing 'ignored' and 'unblamable' respectively for the >> options when using the porcelain modes. > > This looks good to me
Thanks, both of you. Will replace and queue. Let me mark the topic for 'next'.