Re: [PATCH] read-cache: report lock error when refreshing index

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 1, 2025, 19:21 UTC
Message-ID: <xmqqv7obk98v.fsf@gitster.g>
In-Reply-To: <t4czubzmfuihxzmefwwhcel5qyss35gmodhfhvkfyiwitb5osw@d33acdbtds63>

Justin Tobler <jltobler@gmail.com> writes:

Show 8 quoted lines

>>  		test_must_fail git stash create 2>err &&
>> -		test_cmp expect err
>> +		test_grep "error: Unable to create '.*index.lock'" err
>
> The test now checks for the explicit lock error message. The check for
> the "error: could not write index" message is also removed even though
> it should still be present in the output. Should we also continue to
> grep for that message too?

Probably. I was wondering which part of the patch removed the existing message while reading this update to the test.

Thanks.