Re: [PATCH/RFC v2 2/2] diff.tcl: call "apply_tab_size 1" to fix alignment instead of spaces.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 29, 2026, 00:06 UTC
- Message-ID
- <xmqqv7glcmee.fsf@gitster.g>
- In-Reply-To
- <71494127-c17d-4fd9-a69d-1f547205ac8f@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 5 quoted lines
> I think that these values for tabstops aren't optimal. It does not make
> sense to have tabstop at column 1 for diff output, because there is
> always at least one character ('+', '-', or SP), so that the first tab
> would jump right to the second stop. In Gitk, the initial version looked
> like this as well, but it this was changed soon after.True. So instead of setting tabstops at 1, 9, 17, 25, ..., gitk does 9, 17, 25, 33, ..., which makes more sense, but there is no practical difference, no? Because the first column will be the plus, minus, or space and it will never be a tab.