git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] t: fix "that that" typo in lib-unicode-nfc-nfd.sh

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 2, 2026, 21:43 UTC
Message-ID
<xmqqv7fdykk5.fsf@gitster.g>
In-Reply-To
<20260302192627.83631-1-r.siddharth.shrimali@gmail.com>
Siddharth Shrimali <r.siddharth.shrimali@gmail.com> writes:
> In the comments of lib-unicode-nfc-nfd.sh, "that that" was used
> unintentionally. Remove the redundant "that" to improve clarity.
Thanks, will queue.
Show 23 quoted lines
>
> Signed-off-by: Siddharth Shrimali <r.siddharth.shrimali@gmail.com>
> ---
> Changes since v1:
> Dropped changes to t0019 and t6416 as the original "that that" 
> phrasing in those files was grammatically intentional.
>
>  t/lib-unicode-nfc-nfd.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/lib-unicode-nfc-nfd.sh b/t/lib-unicode-nfc-nfd.sh
> index aed0a4dd44..201ab9b24c 100755
> --- a/t/lib-unicode-nfc-nfd.sh
> +++ b/t/lib-unicode-nfc-nfd.sh
> @@ -75,7 +75,7 @@ test_lazy_prereq UNICODE_NFD_PRESERVED '
>  #
>  # Note that I've used the canonical ordering of the
>  # combining characters.  It is also possible to
> -# swap them.  My testing shows that that non-standard
> +# swap them.  My testing shows that non-standard
>  # ordering also causes a collision in mkdir.  However,
>  # the resulting names don't draw correctly on the
>  # terminal (implying that the on-disk format also has
Previous: Siddharth Shrimali
Message 5 of 5 in “t: fix "that that" typos in test comments”
  1. t: fix "that that" typos in test commentsSiddharth Shrimali, Mar 2, 2026
  2. Siddharth ShrimaliMar 2, 2026
  3. Junio C HamanoMar 2, 2026
  4. t: fix "that that" typo in lib-unicode-nfc-nfd.shSiddharth Shrimali, Mar 2, 2026
  5. Junio C HamanoMar 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.