Re: [PATCH 7/7] rerere: get rid of global rerere cache state

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 23, 2026, 17:04 UTC
Message-ID: <xmqqv76s8i12.fsf@gitster.g>
In-Reply-To: <20261023-pks-rerere-wo-the-repository-v1-7-b6ac0c2e4b81@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 8 quoted lines

> The rerere cache state is tracked via a global variable. On the one hand
> this ties it to one specific repository. On the other hand it has the
> consequence that the cache may be leaking state across multiple calls
> into the rerere subsystem.
>
> Refactor the subsystem to instead pass around the rerere cache state
> explicitly and make callers responsible for setting it up and then
> clearing it again.

This step is a logical conclusion of what was done in the previous step. I very much like it.

I was somehow hoping to see that an earlier addition of "enabled" bit to the "struct repository" would be undone and replaced with this structure, but that may not be feasible, I guess.

Queued.