git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PULL] git-svn updates from Ramkumar

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 15, 2015, 23:24 UTC
Message-ID
<xmqqtwzr4ofo.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20150115224652.GA25482@dcvr.yhbt.net>
Eric Wong <normalperson@yhbt.net> writes:
Show 5 quoted lines
> Junio C Hamano <gitster@pobox.com> wrote:
>> Thanks.  No tests necessary/feasible?  Just being curious.
>
> They seemed simple and obvious enough to me,
> (and most importantly, didn't trigger regressions).

I can see that the top-most one is about .git that is a textual symlink ".gitdir: <elsewhere>" and the code after this part needed to convert it to the real place in order to be able to read/write "${GIT_DIR}/<some file>", so that is obvious to me.

But the other one just says "handle missing ref_id case correctly" without clarifying what is incorrect in the original and how the desired correct behaviour is different (in other words, what breaks without this change)

To which a natural reaction was "Can the existing breakage demonstrated by a test?".

If it is obvious for git-svn folks, then I wouldn't complain, though.

Previous: Eric WongNext: Ramkumar Ramachandra
Message 4 of 9 in “[PULL] git-svn updates from Ramkumar”
  1. Eric WongJan 15, 2015
  2. Junio C HamanoJan 15, 2015
  3. Eric WongJan 15, 2015
  4. Junio C HamanoJan 15, 2015
  5. Ramkumar RamachandraJan 15, 2015
  6. Eric WongJan 16, 2015
  7. Ramkumar RamachandraJan 16, 2015
  8. Eric WongJan 16, 2015
  9. Ramkumar RamachandraJan 21, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.