git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH][GSoC] revision: forbid --graph and --no-walk usage

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 6, 2015, 18:30 UTC
Message-ID
<xmqqtwxyyo5u.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1425618810-21192-1-git-send-email-akshayaurora@yahoo.com>
Akshay Aurora <akshayaurora@yahoo.com> writes:
Show 21 quoted lines
> Signed-off-by: Akshay Aurora <akshayaurora@yahoo.com>
> ---
> This is my first patch for a GSoC Microproject, would be great to have your feedback.
>
>  revision.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/revision.c b/revision.c
> index bd027bc..d578652 100644
> --- a/revision.c
> +++ b/revision.c
> @@ -2248,7 +2248,8 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, struct s
>  	 */
>  	if (revs->reverse && revs->graph)
>  		die("cannot combine --reverse with --graph");
> -
> +	if (revs->no_walk && revs->graph)
> +		die("cannot combine --no-walk with --graph");
>  	if (revs->reflog_info && revs->graph)
>  		die("cannot combine --walk-reflogs with --graph");
>  	if (!revs->reflog_info && revs->grep_filter.use_reflog_filter)

Needs a new test to make sure "log --no-walk --graph" is rejected, and also you need to make sure all other existing tests that used to pass before this change still pass.

Previous: Akshay AuroraNext: Akshay Aurora
Message 2 of 4 in “[GSoC] revision: forbid --graph and --no-walk usage”
  1. [GSoC] revision: forbid --graph and --no-walk usageAkshay Aurora, Mar 6, 2015
  2. Junio C HamanoMar 6, 2015
  3. Akshay AuroraMar 6, 2015
  4. Matthieu MoyMar 8, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.