git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase -i: redo tasks that die during cherry-pick

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 29, 2015, 19:41 UTC
Message-ID
<xmqqtwvy4t97.fsf@gitster.dls.corp.google.com>
In-Reply-To
<CABURp0odQWJC9LfQMywHKUarKAe7EY45fHET8xVVEsoBYDzBPg@mail.gmail.com>
Phil Hord <phil.hord@gmail.com> writes:
Show 14 quoted lines
> On Wed, Apr 29, 2015 at 1:15 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Thanks, will queue.
>>
>> Aside from the "much more invasive" possibility, the patch makes me
>> wonder if it would have been a better design to have a static "todo"
>> with a "current" pointer as two state files.  Then reschedule would
>> have been just the matter of decrementing the number in "current",
>> instead of "grab the last line of one file and prepend to the other
>> file, and then lose the last line".
>
> That's an interesting idea.  Changing it now would impact anyone who
> now depends on the current todo/done behavior, and I imagine there
> are many.

Yeah, in case it wasn't clear, I was merely lamenting over water under the bridge, not seriously suggesting to break users to simplify our logic.

Previous: Phil HordNext: Johannes Schindelin
Message 5 of 7 in “rebase -i: redo tasks that die during cherry-pick”
  1. rebase -i: redo tasks that die during cherry-pickPhil Hord, Apr 28, 2015
  2. Johannes SchindelinApr 28, 2015
  3. Junio C HamanoApr 29, 2015
  4. Phil HordApr 29, 2015
  5. Junio C HamanoApr 29, 2015
  6. rebase -i's todo/done list, was Re: [PATCH] rebase -i: redo tasks that die during cherry-pickJohannes Schindelin, Apr 30, 2015
  7. Fabian RuchApr 30, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.