Re: [PATCH] git-completion.tcsh: fix redirect with noclobber

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 9, 2015, 18:20 UTC
Message-ID: <xmqqtwug7nh8.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150609172515.GA20638@yendor.com>

Ariel Faigon <github.2009@yendor.com> writes:

Show 11 quoted lines

> tcsh users who happen to have 'set noclobber' elsewhere in their
> ~/.tcshrc or ~/.cshrc startup files get a 'File exist' error, and
> the tcsh completion file doesn't get generated/updated.
>
> Adding a `!` in the redirect works correctly for both clobber (default)
> and 'set noclobber' users.
>
> Helped-by: Junio C Hamano <gitster@pobox.com>
> Reviewed-by: Christian Couder <christian.couder@gmail.com>
> Signed-off-by: Ariel Faigon <github.2009@yendor.com>
> ---

Thanks for enduring three iterations for a single-liner. This versio will show nicely in "git log -p" output ;-)

In case anybody is wondering, that "Helped-by: notifications@github" was merely because I said "this change makes sense, care to send it over to us at git@vger?" from github UI on Ariel's commit. I do not deserve helped-by for merely encouraging participation.

Will queue.  Thanks again.

Show 17 quoted lines

>
>  contrib/completion/git-completion.tcsh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.tcsh b/contrib/completion/git-completion.tcsh
> index 6104a42..4a790d8 100644
> --- a/contrib/completion/git-completion.tcsh
> +++ b/contrib/completion/git-completion.tcsh
> @@ -41,7 +41,7 @@ if ( ! -e ${__git_tcsh_completion_original_script} ) then
>  	exit
>  endif
>  
> -cat << EOF > ${__git_tcsh_completion_script}
> +cat << EOF >! ${__git_tcsh_completion_script}
>  #!bash
>  #
>  # This script is GENERATED and will be overwritten automatically.