Re: git-clone fails when current user is not in /etc/passwd

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 10, 2015, 19:57 UTC
Message-ID: <xmqqtwnqgjpm.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20151210183426.GA27609@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

> But before we even hit the strict-check, we call xgetpwuid_self(), which
> unconditionally dies on failure. I think that function needs to be
> taught a "gently" form which we use for non-strict ident lookups.
> Unfortunately it's a little non-trivial because the strictness will need
> to get passed all the way down to ident_default_name() (and we need to
> make sure that a non-strict check followed by a strict one does not
> fail; i.e., that the first does not pollute the contents of
> git_default_name).

All true. The adding of "(none)" in add_domainname() I used as an excuse to make the function stop barfing is a symptom coming from the above. That one should die when asked to do a strict thing (there is a corresponding kludge to do strstr "(none)" to cover it up, which is even uglier X-<).