Re: [PATCH v6 00/17] Port branch.c to use ref-filter's printing options

From: Junio C Hamano <gitster@pobox.com>
Date: May 17, 2016, 17:52 UTC
Message-ID: <xmqqtwhwwp0c.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAOLa=ZQ5nUazL61eqj34-v06rueyjzvvJHzp8du7HHGi5=7TMA@mail.gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

> Hello, sorry for the confusion, it's built on top of 'next' which contains
> f307218 (t6302: simplify non-gpg cases). The merge conflict is due to the
> commit made by you 1cca17df (Documentation: fix linkgit references).

That is not "confusion", but an "incorrect piece of information".

The series does not seem to apply on 'next', either.

Where did you exactly rebase on top of? It is not on f307218, it is not on 'next', 'next@{1}',... 'next@{8}'.

f3072180 (t6302: simplify non-gpg cases, 2016-05-09) was merged to 'next' at 9fcb98b2 (Merge branch 'es/test-gpg-tags' into next, 2016-05-10), but the series does not seem to apply there, either.

$ git co 9fcb98b2
Applying: ref-filter: implement %(if), %(then), and %(else) atoms
error: patch failed: Documentation/git-for-each-ref.txt:181
error: Documentation/git-for-each-ref.txt: patch does not apply
Patch failed at 0001 ref-filter: implement %(if), %(then), and %(else) atoms
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Not that a series built on top of any 'next' is directly usable. You are forcing me to identify which topics in 'next' you depend on, and build a topic that does not contain anything unrelated that is in 'next' before starting to apply these patches. Can you pick a more appropriate place to base these patches on, please? Why isn't this based on 'master', for example?