git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] difftool: always honor "command not found" exit code

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 14, 2016, 03:21 UTC
Message-ID
<xmqqtweokpcl.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160813113028.uwedje6fzuc3cuzr@john.keeping.me.uk>
John Keeping <john@keeping.me.uk> writes:
Show 13 quoted lines
> At the moment difftool's "trust exit code" logic always suppresses the
> exit status of the diff utility we invoke.  This is useful because we
> don't want to exit just because diff returned "1" because the files
> differ, but it's confusing if the shell returns an error because the
> selected diff utility is not found.
>
> POSIX specifies 127 as the exit status for "command not found" and 126
> for "command found but is not executable" [1] and at least bash and dash
> follow this specification, while diff utilities generally use "1" for
> the exit status we want to ignore.
>
> Handle 126 and 127 as special values, assuming that they always mean
> that the command could not be executed.
Sounds like a reasonable thing to do.  Will queue; thanks.
Previous: John KeepingNext: David Aguilar
Message 4 of 5 in “git difftool and git mergetool aren't returning errors when the tool has issues”
  1. Tom Tanner (BLOOMBERG/ LONDON)Aug 12, 2016
  2. John KeepingAug 13, 2016
  3. difftool: always honor "command not found" exit codeJohn Keeping, Aug 13, 2016
  4. Junio C HamanoAug 14, 2016
  5. David AguilarAug 13, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.