Re: [PATCH v1] diffcore-rename: speed up register_rename_src

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 21, 2017, 01:19 UTC
Message-ID: <xmqqtw5i7e16.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170420183455.y5oz3hspz3v2g6yr@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 6 quoted lines

>   - this patch probably adds "unsorted tree" to the list of breakages
>     that would cause us to skip rename detection. I don't know if that's
>     actually possible in practice (i.e., do we end up sorting the
>     diffq elsewhere anyway?). I also wondered if it might run afoul of
>     diffcore_order(), but that is applied after rename detection, so
>     we're OK.

One of the frontends (I think it was diff-index) couldn't generate sorted output (which is input to diffcore-* machinery) but I think diffq is sorted before getting passed to the diffcore-* machinery in that codepath, so we should be also OK on that front.