git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix minor typo in git-diff docs.

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 31, 2017, 16:59 UTC
Message-ID
<xmqqtw1silu3.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CA+dzEB=cDvp7ZS8x+p+U-5NbK3SNd0FPyj_wP=gvi8mJi6D2ag@mail.gmail.com>
Anthony Sottile <asottile@umich.edu> writes:
Show 13 quoted lines
> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
> index 89cc0f4..43d18a4 100644
> --- a/Documentation/diff-options.txt
> +++ b/Documentation/diff-options.txt
> @@ -392,7 +392,7 @@ endif::git-log[]
>         the diff between the preimage and `/dev/null`. The resulting patch
>         is not meant to be applied with `patch` or `git apply`; this is
>         solely for people who want to just concentrate on reviewing the
> -       text after the change. In addition, the output obviously lack
> +       text after the change. In addition, the output obviously lacks
>         enough information to apply such a patch in reverse, even manually,
>         hence the name of the option.
>  +

Another thing that is more severe. You seem to have replaced all leading tabs with whitespaces, which makes the patch unusable. For this single character patch, I can pretend as if I applied your patch while making the fix myself in my editor, so there is no need to resend, but please make sure your e-mail client does not do that the next time.

Thanks.  Queued.
Previous: Junio C HamanoNext: Anthony Sottile
Message 3 of 4 in “Fix minor typo in git-diff docs.”
  1. Fix minor typo in git-diff docs.Anthony Sottile, Jul 31, 2017
  2. Junio C HamanoJul 31, 2017
  3. Junio C HamanoJul 31, 2017
  4. Anthony SottileJul 31, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.