git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: reftable [v6]: new ref storage format

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 8, 2017, 19:01 UTC
Message-ID
<xmqqtw1hc28z.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CAJo=hJtg0PAVHT1phbArdra8+4LfnEEuaj3fBid==BXkZghi8g@mail.gmail.com>

I notice that you raised the location of restart table within a block in this iteration (or maybe it happened in v5).

This forces you to hold all contents in core before the first byte is written out. You start from the first entry (which will become the first restart entry), emit a handful as prefix compressed entries, emit a full entry (which will become the next restart entry), ... until you have enough to fill both the data and the restart table, then start writing from the header (which needs the length of the block), restart table and then data.

I think it is OK to do so for the blocks whose size is limited to 16M, but I wonder if it is sensible to do the same for the index block whose limit is 2G. If you keep the restart table after the data, then you could stream out the entries as you emit, write the restart table, and then seek back to fix the length in the header, without holding the 2G in core, no?

Previous: Jeff KingNext: Shawn Pearce
Message 6 of 12 in “Re: reftable [v6]: new ref storage format”
  1. Shawn PearceAug 7, 2017
  2. Stefan BellerAug 7, 2017
  3. Shawn PearceAug 7, 2017
  4. Stefan BellerAug 8, 2017
  5. Jeff KingAug 8, 2017
  6. Junio C HamanoAug 8, 2017
  7. Shawn PearceAug 8, 2017
  8. Junio C HamanoAug 8, 2017
  9. Shawn PearceAug 9, 2017
  10. Junio C HamanoAug 8, 2017
  11. Shawn PearceAug 8, 2017
  12. Michael HaggertyAug 14, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.