Re: [PATCH] protocol: treat unrecognized protocol.version setting as 0

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 28, 2018, 18:06 UTC
Message-ID: <xmqqtvu1kmzo.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <xmqq7eqxm22w.fsf@gitster-ct.c.googlers.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 14 quoted lines

> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>>> I wonder if it's better to specify multiple versions. If v2 is not
>>> recognized by this git but v0 is, then it can pick that up. But if you
>>> explicitly tell it to choose between v2 and v3 only and it does not
>>> understand either, then it dies. Not sure if this is a good idea
>>> though.
>>
>> Interesting thought.  Something roughly like this (on top of the patch
>> this is a reply to)?
>
> I am OK with that, i.e. allow the user to tell us what is acceptable
> and pick from them, as long as the blind "we do not know so let's
> fall back to v0" is removed.

Sorry, but "as long as" was a bit too strong. I am not convinced that the "treat unrecognized one as if it were 0" is a good idea for the reasons I gave in the my earlier response, but I am not yet convinced that erroring out is the best solution, either.

So s/as long as/but it may be better if/, perhaps.