Re: [PATCH v3 3/8] refs: new ref types to make per-worktree refs visible to all worktrees

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 25, 2018, 01:19 UTC
Message-ID: <xmqqtvk60xa3.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <87a7ly1djb.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 24 quoted lines

> On Sun, Oct 21 2018, Nguyễn Thái Ngọc Duy wrote:
>
> This change has a regression in 2.20:
>
>> [...]
>>  static void files_reflog_path(struct files_ref_store *refs,
>>  			      struct strbuf *sb,
>>  			      const char *refname)
>> @@ -158,6 +178,9 @@ static void files_reflog_path(struct files_ref_store *refs,
>>  	case REF_TYPE_PSEUDOREF:
>>  		strbuf_addf(sb, "%s/logs/%s", refs->gitdir, refname);
>>  		break;
>> +	case REF_TYPE_OTHER_PSEUDOREF:
>> +	case REF_TYPE_MAIN_PSEUDOREF:
>> +		return files_reflog_path_other_worktrees(refs, sb, refname);
>>  	case REF_TYPE_NORMAL:
>>  		strbuf_addf(sb, "%s/logs/%s", refs->gitcommondir, refname);
>>  		break;
>
> SunCC on Solaris hard errors on this:
>
>     "refs/files-backend.c", line 183: void function cannot return value
>
> Needs to be files...(); break; instead.

True.

The caller itself returns "void", so it would be nice if this were a mere warning() from practical usabliity's point of view, though ;-)