Re: [PATCH 1/1] configure.ac: Properly check for libintl

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 19, 2019, 06:37 UTC
Message-ID: <xmqqtveucxgu.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190419051249.oiypxcs6hexjdf2d@vkochan-ThinkPad-T470p>

Vadim Kochan <vadim4j@gmail.com> writes:

Show 15 quoted lines

>> I think
>> 
>> 	autoconf: #include <libintl.h> when checking for gettext()
>> 
>> is probably a better title.  
>> 
>> Together with your originally proposed log message, which we now
>> know explains why this inclusion makes a difference sufficiently to
>> be understandable by an average Git developer, the resulting commit
>> will communicate to our future developers the reason why we thought
>> this was a good change clearly.
>> 
>> Thanks.
>
> Thanks! Should I re-submit patch with title updated v2 ?

You could if you feel like it, but in a case like this, responding with "Yeah, I agree with your suggestion" and telling me to retitle is sufficient, if you have nothing else to change in the v2.

I've already did the retitling while queuing it, so no need to resend.

Thanks.