Re: [PATCH] config.mak.dev: re-enable -Wformat-zero-length

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 28, 2020, 16:42 UTC
Message-ID: <xmqqtv3aek8o.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20200227235445.GA1371170@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> The short of it is that we probably can't just disable the warning for
> everybody because of portability issues. And ignoring it for developers
> puts us in the situation we're in now, where non-dev builds are annoyed.

"git blame" unfortunately is very bad at poing at a commit that removed something, so I do not offhand know how much it would help readers who later wonder "oh, I am sure we had thing to disable format-zero-length warning, and I want to learn the reason why we dropped it", but thanks for writing this down.

Show 25 quoted lines

> Since the workaround is both rarely needed and fairly straight-forward,
> let's just commit to doing it as necessary, and re-enable the warning.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> I had totally forgotten about that thread until researching the history
> just now. There's another option there involving #pragma, but it was too
> gross for me to even suggest now as an alternative in the commit
> message. ;) I think this is the most practical improvement.
>
>  config.mak.dev | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/config.mak.dev b/config.mak.dev
> index bf1f3fcdee..89b218d11a 100644
> --- a/config.mak.dev
> +++ b/config.mak.dev
> @@ -9,7 +9,6 @@ endif
>  DEVELOPER_CFLAGS += -Wall
>  DEVELOPER_CFLAGS += -Wdeclaration-after-statement
>  DEVELOPER_CFLAGS += -Wformat-security
> -DEVELOPER_CFLAGS += -Wno-format-zero-length
>  DEVELOPER_CFLAGS += -Wold-style-definition
>  DEVELOPER_CFLAGS += -Woverflow
>  DEVELOPER_CFLAGS += -Wpointer-arith