Re: [PATCH] fast-import: fix incomplete conversion with multiple mark files

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 8, 2020, 16:47 UTC
Message-ID: <xmqqtuzlld1d.fsf@gitster.c.googlers.com>
In-Reply-To: <alpine.DEB.2.21.2006081739520.9949@serpens>

Tibor Billes <tbilles@gmx.com> writes:

Show 9 quoted lines

> On Sat, 6 Jun 2020, brian m. carlson wrote:
>
>> When ddddf8d7e2 ("fast-import: permit reading multiple marks files",
>> 2020-02-22) converted fast-import to handle multiple marks files in
>> preparation for submodule support, the conversion was incomplete.
>...
>
> Thanks for the quickly patching it! I tested the patch and I can confirm this
> solves the memory leak for me.

Tibor, thanks for testing.

Brian, I notice that the singleton global "marks_set_count", even though the number could be counted per instance of the mark_set structure, is still singleton. I didn't bother thinking about it when I wrote my "perhaps along this line" patch, but now I read it again, I think it is OK to leave it (and other stats counters) as is, primarily because we don't have a need (yet) to show stats per mark_set. Did you leave it as a global for the same reason? Just sanity-checking.

Thanks.