git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t3200: don't grep for `strerror()` string

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 18, 2020, 17:59 UTC
Message-ID
<xmqqtuy4bt7f.fsf@gitster.c.googlers.com>
In-Reply-To
<20200718094840.31269-1-martin.agren@gmail.com>
Martin Ågren <martin.agren@gmail.com> writes:
Show 18 quoted lines
> In 6b7093064a ("t3200: test for specific errors", 2020-06-15), we
> learned to grep stderr to ensure that the failing `git branch`
> invocations fail for the right reason. In two of these tests, we grep
> for "File exists", expecting the string to show up there since config.c
> calls `error_errno()`, which ends up including `strerror(errno)` in the
> error message.
>
> But as we saw in 4605a73073 ("t1091: don't grep for `strerror()`
> string", 2020-03-08), there exists at least one implementation where
> `strerror()` yields a slightly different string than the one we're
> grepping for. In particular, these tests fail on the NonStop platform.
>
> Similar to 4605a73073, grep for the beginning of the string instead to
> avoid relying on `strerror()` behavior.
>
> Reported-by: Randall S. Becker <rsbecker@nexbridge.com>
> Signed-off-by: Martin Ågren <martin.agren@gmail.com>
> ---

Yup, that looks like a good description and a fix to check only the parts of the message we write, ignoring what the system library may add.

Show 5 quoted lines
>  Hi Randall,
>
>  Does this fix the test for you?
>
>  Martin
Hopefully it would ;-)
Previous: Martin ÅgrenNext: Martin Ågren
Message 4 of 7 in “[ANNOUNCE] Git v2.28.0-rc1”
  1. Junio C HamanoJul 17, 2020
  2. Randall S. BeckerJul 17, 2020
  3. t3200: don't grep for `strerror()` stringMartin Ågren, Jul 18, 2020
  4. Junio C HamanoJul 18, 2020
  5. Martin ÅgrenJul 18, 2020
  6. Randall S. BeckerJul 19, 2020
  7. Randall S. BeckerJul 19, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.