git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Aborting git rebase --edit-todo

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 3, 2020, 21:08 UTC
Message-ID
<xmqqtuwe8t5s.fsf@gitster.c.googlers.com>
In-Reply-To
<CAG0OSgcUi6sKJQmUEd4-Lu5qAiQqKk7X7aSRvRtcBWkcKj4f1g@mail.gmail.com>
Victor Toni <victor.toni@gmail.com> writes:
Show 23 quoted lines
>> I think the implementor chose the first interpretation.  The "drop"
>> insn is a relatively recent invention, and back when it was missing
>> from the vocabulary, I do not think it was possible to say " discard
>> all the rest" without emptying the todo list, so that design is
>> understandable.
>>
>> Now we have the "drop" verb, the latter interpretation becomes
>> possible without making it impossible for the user to express the
>> former.  It might be a good idea to
>>
>>  (1) save away the original before allowing --edit-todo to edit,
>>
>>  (2) open the editor, and
>>
>>  (3) when getting an empty buffer back, go back to step (2) using
>>      the back-up made in step (1).
>>
>> Either way, the todo list editor buffer can have additional comment
>> instructing what happens when the buffer is emptied.
>>
> Personally I would like to see your approach (1,2,3) implemented
> because it is not destructive. If the user wants to achieve something
> different he can retry.

Obviously I agree that the approach would be nicer than the status quo. It would not be as trivial as a microproject, but would be a good bite-sized starter-task for those aspiring developers who want to dip their toes in the water to start hacking on the codebase ;-)

Previous: Victor ToniNext: Victor Toni
Message 9 of 14 in “Aborting git rebase --edit-todo”
  1. Victor ToniSep 3, 2020
  2. Junio C HamanoSep 3, 2020
  3. Carlo ArenasSep 3, 2020
  4. Victor ToniSep 3, 2020
  5. Junio C HamanoSep 3, 2020
  6. Victor ToniSep 3, 2020
  7. Carlo ArenasSep 3, 2020
  8. Victor ToniSep 3, 2020
  9. Junio C HamanoSep 3, 2020
  10. Victor ToniSep 3, 2020
  11. Johannes SchindelinSep 4, 2020
  12. Junio C HamanoSep 6, 2020
  13. Johannes SchindelinSep 4, 2020
  14. Johannes SchindelinSep 4, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.