git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] http: automatically retry some requests

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 12, 2020, 21:00 UTC
Message-ID
<xmqqtuuzma6l.fsf@gitster.c.googlers.com>
In-Reply-To
<nycvar.QRO.7.76.6.2010122126280.50@tvgsbejvaqbjf.bet>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 25 quoted lines
> Hi Sean,
>
> On Mon, 12 Oct 2020, Sean McAllister wrote:
>
>> Some HTTP response codes indicate a server state that can support
>> retrying the request rather than immediately erroring out.  The server
>> can also provide information about how long to wait before retries to
>> via the Retry-After header.  So check the server response and retry
>> some reasonable number of times before erroring out to better accomodate
>> transient errors.
>>
>> Exiting immediately becomes irksome when pulling large multi-repo code
>> bases such as Android or Chromium, as often the entire fetch operation
>> has to be restarted from the beginning due to an error in one repo. If
>> we can reduce how often that occurs, then it's a big win.
>
> Makes a lot of sense to me.
> ...
>> +http.retryLimit::
>> +	Some HTTP error codes (eg: 429,503) can reasonably be retried if
>
> Please have a space after the comma so that it is not being mistaken for a
> 6-digit number. Also, aren't they called "status codes"? Not all of them
> indicate errors, after all.
> ...

I've read your comments and agree to them all. Thanks for a detailed and excellent review.

Previous: Johannes SchindelinNext: Sean McAllister
Message 5 of 13 in “replace CURLOPT_FILE With CURLOPT_WRITEDATA”
  1. 2/3 replace CURLOPT_FILE With CURLOPT_WRITEDATASean McAllister, Oct 12, 2020
  2. Johannes SchindelinOct 12, 2020
  3. 3/3 http: automatically retry some requestsSean McAllister, Oct 12, 2020
  4. Johannes SchindelinOct 12, 2020
  5. Junio C HamanoOct 12, 2020
  6. Sean McAllisterOct 13, 2020
  7. Junio C HamanoOct 13, 2020
  8. remote-curl: add testing for intelligent retry for HTTPSean McAllister, Oct 12, 2020
  9. Junio C HamanoOct 12, 2020
  10. Sean McAllisterOct 12, 2020
  11. Junio C HamanoOct 12, 2020
  12. Johannes SchindelinOct 13, 2020
  13. Junio C HamanoOct 13, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.