Re: [PATCH 1/2] fsck: make symlinked .gitignore and .gitattributes a warning

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 16, 2021, 01:56 UTC
Message-ID: <xmqqtuqcsrkt.fsf@gitster.c.googlers.com>
In-Reply-To: <YCsc0OePtrotjeg5@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> That said, they'd probably want to checkout those old commits, too. So
> we probably do need a config override, even if it's a broad one ("trust
> me, this repo is OK, just allow symlinks for these special files").

Is this about the check that is overly strict for some existing projects that kept the jk/symlinked-dotgitx-files topic in the 'seen' so far?

On the fsck end, we know we can demote the error level per repository, but I wonder if we should make checkout/clone honor the same setting?

I think GITMODULES_SYMLINK has been there for quite some time at "error" level and we do want to discourage it to be a symbolic link, so I am not quite sure what the demoting of these two achieves. Why aren't we having a similar issue on .gitmodules that is a symbolic link?

Thanks.