Re: [PATCH v2 06/10] grep/pcre2: use compile-time PCREv2 version test
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 4, 2021, 00:14 UTC
- Message-ID
- <xmqqtuprhj1s.fsf@gitster.c.googlers.com>
- In-Reply-To
- <20210218000728.13995-7-avarab@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> +#if (PCRE2_MAJOR >= 10 && PCRE2_MINOR >= 36) || PCRE2_MAJOR >= 11 > +#define GIT_PCRE2_VERSION_10_36_OR_HIGHER > +#endif
This is not wrong per-se but it does look misleading not to spell it as
#if (PCRE2_MAJOR == 10 && PCRE2_MINOR >= 36) || PCRE2_MAJOR >= 11
which would convey the intention much clearly.
Hint to notice the difference: imagine if it were "9.37 and later in 9.X series, 10.36 and later in 10.X series and anything after 11 are OK".
In other words, the minor version is always tied to a particular major version and "major >= X && minor >= Y" is often a bug, even though in this case it happens to be OK only because 10 and 11 are consecutive.